Skip to content

On beta, adds callout for feedback/beta signup/equivalent legacy pages #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 10, 2019

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Dec 4, 2019

For review by @cwaring and @ericronne on the understanding that this isn't exactly as visually proposed in the original content thread and could likely be more efficiently built, but it gets the job done for something that will only be a temporary part of the beta. Y'all can discuss how much it's worth tweaking. 😉 This completes the work that allows us to close ipfs-inactive/docs#341.

  • Adds "this is a beta" callout to the bottom of all content pages (based visually on existing "tip" styles)
  • Includes a link to the equivalent legacy page when one exists
  • Includes a link to submit feedback (as a generic documentation issue on GitHub in the legacy repo)
  • Includes a link to the beta test signup form (using same logic as in the content stub pages)

Example below; note that the "View this page on legacy site" link doesn't appear if there's no equivalent page on legacy.
image

@jessicaschilling jessicaschilling changed the title Feat legacy callouts On beta, adds callout for feedback/beta signup/equivalent legacy pages Dec 4, 2019
Copy link

@ericronne ericronne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want to use the tip style i spec'd in this issue once it's been added to the code, but looks merge-able to me!

@jessicaschilling
Copy link
Contributor Author

Leaving this PR open until @cwaring determines if/whether/how this should be incorporated into a site footer.

@ericronne
Copy link

My commit moves the feature suggestion to this legacy callout, but requires additional formatting by Sir @cwaring. 🙏

As of this commit …

image

Desired design …

image

To do …

  • Add vertical spacing above the callout (should match spacing between major page sections)
  • Split the four links into two columns on desktop
  • Change the "View this page on legacy site" to regular (thinner) weight font

Related: This issue to remove the feature request from the header

@cwaring cwaring changed the base branch from master to feat/metrics-widget December 10, 2019 21:15
@cwaring cwaring merged commit 66488d2 into feat/metrics-widget Dec 10, 2019
@cwaring cwaring deleted the feat-legacy-callouts branch December 10, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants